Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data validation tests to CI #172

Open
jklmnn opened this issue Feb 8, 2019 · 0 comments
Open

Add data validation tests to CI #172

jklmnn opened this issue Feb 8, 2019 · 0 comments
Projects

Comments

@jklmnn
Copy link
Member

jklmnn commented Feb 8, 2019

After merging #171 I noticed that Bonn was marked invalid on https://jklmnn.github.io/parkendd-status/. I think we should add data validation tests to the CI chain.

The invalid data was caused by the default of free lots to be "unbekannt" instead of an integer as defined by https://github.com/offenesdresden/ParkAPI/wiki/city.json. Although I have to admit this document seems to be outdated. The current checks of the check page are done against https://github.com/jklmnn/parkendd-status/blob/gh-pages/schema_city.json.
Nevertheless the invalid data cannot be handled by the Android App so I fixed this behaviour in c951c72.

@Mechtecs I assume you either used this default due to missing documentation or because you wanted to distinguish between full and unknown lots? In the first case you could pull this fix into your fork. Generally such a distinction would be helpful yet incompatible to the current API.

@jklmnn jklmnn added this to To do in ParkAPI 1.0 via automation Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
ParkAPI 1.0
  
To do
Development

No branches or pull requests

1 participant