Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formulation of "gradient limit" needs rework #1085

Open
p-snft opened this issue Jun 24, 2024 · 0 comments
Open

Formulation of "gradient limit" needs rework #1085

p-snft opened this issue Jun 24, 2024 · 0 comments

Comments

@p-snft
Copy link
Member

p-snft commented Jun 24, 2024

The formulation of the gradient limit is at least hard to follow. I think I did not alter it in #1077 but @jokochems, ,who changed it before, now means it smells (see #1077 (comment)). If there is an issue, it will become obvious at latest with #1080.

At the same time, it also needs rework as it does not consider the lenght of the time steps but limits the delta between two time steps. This means, it is not possible to have a constant ramp in non-equidistant time grids.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant