Make invest relations iterable #1063
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only black and coveralls fails, as in all the PRs. @jokochems could you review the adaptions in this PR please? |
p-snft
approved these changes
May 29, 2024
There was a problem hiding this comment.
To me, this looks reasonable. I approve, as it shouldn't break single-period optimization. I'd also be glad to hear @jokochems if it makes sense to have this for multi-period models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the invest relations can not change in between the periods of a multi-period investment. I dont see a reason why this shouldnt be possible, so I just change the few necessary parts.
@jokochems was there a specific reason why you did not adapt this as well or did you just not need it?