From 6d587ce5a1c8b3e16297c9e965c6b299c738e0d4 Mon Sep 17 00:00:00 2001
From: Tamir David <tamirdavid@Tamirs-MacBook-Pro.local>
Date: Wed, 26 Jun 2024 17:56:26 +0300
Subject: [PATCH] fix: fix comments

---
 collector/processors/odigossamplingprocessor/README.md         | 2 +-
 .../odigossamplingprocessor/internal/sampling/latency.go       | 3 ++-
 collector/processors/odigossamplingprocessor/processor.go      | 3 +--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/collector/processors/odigossamplingprocessor/README.md b/collector/processors/odigossamplingprocessor/README.md
index c18466ded..b061967c6 100644
--- a/collector/processors/odigossamplingprocessor/README.md
+++ b/collector/processors/odigossamplingprocessor/README.md
@@ -18,7 +18,7 @@ This processor samples traces based on the following supported rules:
           "service": "frontend"
 ```
 - threshold: The maximum allowable trace duration in milliseconds. Traces with a duration less than this value will be deleted.
-- endpoint: The specific HTTP route to match for sampling. Only traces with this route will be considered.
+- endpoint: The specific HTTP route prefix to match for sampling. Only traces with routes starting with this prefix will be considered. For example, configuring /buy will also match /buy/product.
 - service: The name of the service for which the rule applies. Only traces from this service will be considered.
 
 
diff --git a/collector/processors/odigossamplingprocessor/internal/sampling/latency.go b/collector/processors/odigossamplingprocessor/internal/sampling/latency.go
index 91ca57c04..bfab156e1 100644
--- a/collector/processors/odigossamplingprocessor/internal/sampling/latency.go
+++ b/collector/processors/odigossamplingprocessor/internal/sampling/latency.go
@@ -6,6 +6,7 @@ import (
 
 	"go.opentelemetry.io/collector/pdata/pcommon"
 	"go.opentelemetry.io/collector/pdata/ptrace"
+	semconv "go.opentelemetry.io/otel/semconv/v1.4.0"
 )
 
 type TraceLatencyRule struct {
@@ -38,7 +39,7 @@ func (tlr *TraceLatencyRule) DropTrace(td ptrace.Traces) bool {
 
 	// Check if the service matches
 	for r := 0; r < resources.Len(); r++ {
-		serviceAttr, _ := resources.At(r).Resource().Attributes().Get("service.name")
+		serviceAttr, _ := resources.At(r).Resource().Attributes().Get(string(semconv.ServiceNameKey))
 		if serviceAttr.AsString() == tlr.Service {
 			serviceFound = true
 		}
diff --git a/collector/processors/odigossamplingprocessor/processor.go b/collector/processors/odigossamplingprocessor/processor.go
index b39203981..93b354fd1 100644
--- a/collector/processors/odigossamplingprocessor/processor.go
+++ b/collector/processors/odigossamplingprocessor/processor.go
@@ -2,7 +2,6 @@ package odigossamplingprocessor
 
 import (
 	"context"
-	"fmt"
 
 	"github.com/open-telemetry/opentelemetry-collector-contrib/odigos/processor/odigossamplingprocessor/internal/sampling"
 	"go.opentelemetry.io/collector/pdata/ptrace"
@@ -25,7 +24,7 @@ func (sp *samplingProcessor) processTraces(ctx context.Context, td ptrace.Traces
 				return td, nil
 			}
 		default:
-			fmt.Printf("Unknown rule details type for rule %s\n", rule.Name)
+			sp.logger.Error("Unknown rule details type", zap.String("rule", rule.Name))
 		}
 	}
 	return td, nil