-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT]: Please support fetching the secret asynchronously #486
Comments
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
Yes I think #262 would solve my ask exactly. Now I was imagining it was a service rather than just a function but an async function will work too. |
Describe the need
I need to fetch the secret from Key Vault and it can change over the lifecycle of the container.
The code you have to verify the signature is to fetch the secret at configure time and not asynchronous...
At startup we are initializing it like this...
This works but there are a couple of problems with this:
Now there is a couple of ways that you could solve this but in my opinion simply adding some kind of
IWebhookSecret
interface which has an async methodpublic Task<string> GetSecret()
would work great.That way I could inject an instance of an object that knows how to reach out to my
ISecretClient
and dynamically fetch before validating.SDK Version
Octokit.net 11.0.1
API Version
N/A
Relevant log output
Code of Conduct
The text was updated successfully, but these errors were encountered: