-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some notes to upgrade the project #30
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First, thanks @larryboymi for this project, it made the job much easier!
I got this project working using Windows/VSCode. I upgraded all dependencies to the latest package versions as of 21-Nov-2019 and deployed the zip file to AWS Lambda with Node 12.x. After upgrade
npm install
reports0 vulnerabilities
, having said that, there are a lot of depreciated functions that should to be updated that I didn't get around to.I made some notes while I was getting this working which are copied below. They essentially describe how I did some basic updates to the code and some tips for config and deployment. I thought this might help others, and maybe could be a starting point to refresh the project. Sry, didn't have time to do a PR.
Upgrading packages
ncu -u
to update packages.jsonpackages-lock.json
(I usually delete the node_modules directory to be sure)/util/generateRSAKeyPair.js
as follows:Run
npm i
ornpm run dist
and you should see0 vulnerabilities
Clearly still a bit of cleanup required to get this fully updated, some areas might be:
Other Tips
npm run dist
in bash shell (not powershell/cmd/etc) to allow the commands in package.json likemv
and other bash style commands to work.s3Folder
in config.js (empty is not valid)Example config
I rearranged the config a bit, just feels a bit more readable to me. If you modify the default config.js then make sure to update the ACME_DIRECTORY_URLs to the latest.
Save raw cert files
I also edited createV2Certificate.js, and added a function to save a bunch of raw certificate files.
Copy in this function and change
saveCertificate
tosaveCerts
.The text was updated successfully, but these errors were encountered: