-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mind the gap #1111
Labels
good-first-issue
Good for newcomers
Comments
Closed
panglesd
added a commit
to panglesd/odoc
that referenced
this issue
Jun 10, 2024
Since the introduction of the grid system, margin collapse did not work between the preamble and content as they are not in the same element. It makes sense to have them in the same element, as they are to be displayed in a single flow. Signed-off-by: Paul-Elliot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
So, if I have this in a .mli:
The layout will have a (relatively, to my eyes) absolutely massive (some people have said I have a tendency to exaggerate) gap above the first heading (i.e. between preamble and content):
I mentioned this in a slack and it was suggested that this gap might be a bug introduced on some redesign of the CSS. In the first couple of screenshots of this PR the screenshots do not have the gap, for example.
At any rate, I don't know whether the gap is intentional design or not, but I do personally find the gap distracting. I'd like to structure the content of documentation with headings without having the gap between the preamble and the content.
The text was updated successfully, but these errors were encountered: