Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature help showing when it shouldn't #1162

Open
faldor20 opened this issue Jul 6, 2023 · 0 comments
Open

Signature help showing when it shouldn't #1162

faldor20 opened this issue Jul 6, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@faldor20
Copy link
Contributor

faldor20 commented Jul 6, 2023

Signature help seems to show up event when it clearly shouldn't
Example:

let add a b =a + b in !!
!!
add 1 1;; !!
!!

Placing the cursor at any of the locations marked !! in this list and pressing "space" will cause the signature help popup to appear.

Signature help should not appear when:

  • The scope has closed with a ;; or in
  • The parameters of the function are already filled: eg: add 1 2 should not trigger signature help after 2 because both of the params are satisfied
@jfeser jfeser added the bug Something isn't working label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfeser @faldor20