-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enrich Merlin telemetry with GC info #1680
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For our performance analysis, it would be very useful to enhance the Merlin telemetry.
Current telemetry
Currently, the Merlin telemetry only contains time information. That timing information is broken down into the various Merlin phases: time spent during the reader phase, the preprocessor phase, the typer phase etc.
Proposed telemetry additions
It would be extremely useful to add memory and general GC information to that. Concretely, when running an
ocamlmerlin
query, I'd love to see information aboutocamlmerlin
, including the cached memory from before. This can be captured in different ways. I think the total memory usage at its peak would be enough.This new telemetry should be similarly broken down into the various Merlin phases as the timing telemetry.
Motivation for telemetry additions
In general, for performance analysis, it's useful to have insight into the memory footprint. Concretely, I have three concrete use cases in mind:
Discussion on CLI details
Do we want this enriched telemetry always or only when opted in in some way? As a heads-up: I'm also enriching the telemetry in other ways, so having full telemetry always would be quite verbose.
The text was updated successfully, but these errors were encountered: