New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancellation #1638
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As far as I understand, Merlin doesn't cancel any incoming queries. I.e., when using Merlin, cancellation has to be done on the editor's side. LSP does have a cancellation workflow, but only on the level of the query queue. Its good impact on performance shows that it's a good thing to have cancellation on the server side.
We can improve the behavior of both Merlin and LSP wrt cancelation by implementing cancelation on the level of the query execution: Before starting a next heavy task, Merlin checks whether a new query is in and, if so, cancels the ongoing query execution.
First, most simple approach:
Possibly, next, we can see if we want to improve that:
The text was updated successfully, but these errors were encountered: