Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to split a types module out from notify-listen-beam #186

Open
madeline-os opened this issue Feb 17, 2022 · 2 comments
Open

Need to split a types module out from notify-listen-beam #186

madeline-os opened this issue Feb 17, 2022 · 2 comments

Comments

@madeline-os
Copy link
Collaborator

The HasNotification and HasChangeNotification classes need to be accessible to GHCJS so they should be decoupled from the backend-specific beam code.

@cgibbard
Copy link
Collaborator

Wait, why do they need to be accessible to the frontend? I can't see a reason.

@madeline-os
Copy link
Collaborator Author

They don't, but you want them to be in the common code so you don't have orphans when defining your schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants