Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlight.js not recognized as non-es5 #53

Open
trigun539 opened this issue Sep 29, 2020 · 2 comments
Open

highlight.js not recognized as non-es5 #53

trigun539 opened this issue Sep 29, 2020 · 2 comments
Labels
Hacktoberfest Hacktoberfest 2021

Comments

@trigun539
Copy link

Highlight v10 starts to use es6 features but it is not getting picked up by are-you-es5.

@obahareth
Copy link
Owner

@trigun539 Can you share how you installed highlight.js? When I did an npm install it looks like I got a package intended for Node.js and I don't see any ES6 syntax in its index file at least (although lib/core.js uses classes). I looked at their build pipeline and I noticed that building for the browser is supported but I'm not sure how to get that version. Is the version that's installed via NPM intended for browser usage?

I think this case could have been caught if #2 is implemented.

@trigun539
Copy link
Author

@obahareth I did simple npm i -D highlight.js Yes, it seems like it will be fixed when #2 is fixed. Just wanted to add it in there as another use case/example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Hacktoberfest 2021
Projects
None yet
Development

No branches or pull requests

2 participants