Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotlight shadows don't work on device in mobile render pipeline #17919

Open
pwalterscarb opened this issue May 14, 2024 · 2 comments
Open

Spotlight shadows don't work on device in mobile render pipeline #17919

pwalterscarb opened this issue May 14, 2024 · 2 comments
Labels
feature/graphics This item is related to the Atom renderer or graphics. kind/bug Categorizes issue or PR as related to a bug. sig/graphics-audio Categorizes an issue or PR as relevant to SIG graphics-audio.

Comments

@pwalterscarb
Copy link

Spotlight shadows don't work on device in mobile render pipeline.

I did some testing, reworked the lighting so shadows should be more obvious and I don't think spotlights are casting shadows on device? They work in editor, just not on iphone. Spotlights are fairly new in the mobile render pipeline.

I can see shadows in editor in the mobile render pipeline.
2024-05-11 13_13_28-O3DE Editor

This is how it looks on device, the spotlight doesn't seem to have shadows.
MW_iPhone_lighting

Found in Branch
https://github.com/carbonated-dev/o3de
Commit ID from o3de/o3de Repository
custom engine version 2310.2

Desktop/Device:
Device: [PC]
OS: [Windows]
Version [10]
CPU [Intel(R) Xeon(R) CPU E5-1650 v3 @ 3.50GHz, 3501 Mhz, 6 Core(s), 12 Logical Processor(s)]
GPU [NVIDIA GeForce RTX 3090]
Memory [32GB]

To test:

  • We work in our branch with vehicles that have a specific setup, so without having to jump to our branch you could try to set up a blank scene with no lights except for one spotlight, directional light and the default ground plane and shader ball.
  • Add a spotlight
  • Aim the spotlight at the shaderball
  • Delete the directional light
  • Might want to turn the skybox lighting down or off so the shadows are easier to see
  • Turn shadows on for the spotlight
  • Send that level to build for iphone and test on the iphone with the mobile render pipeline and see if shadows work
@pwalterscarb pwalterscarb added kind/bug Categorizes issue or PR as related to a bug. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 14, 2024
@michalpelka michalpelka added feature/graphics This item is related to the Atom renderer or graphics. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 16, 2024
@byrcolin byrcolin added the sig/graphics-audio Categorizes an issue or PR as relevant to SIG graphics-audio. label May 21, 2024
@moudgils
Copy link
Contributor

moudgils commented May 22, 2024

To me this looks like the spotlight itself is not working. For example in the second picture the floor of the van is not getting lit by the spotlight. If the spotlight is somehow disabled then you will not see any shadows from it. It is possible that the spotlight may be getting culled incorrectly in this case. Does this issue repro 100%? Tagging @akioCL for visibility.

@akioCL
Copy link
Contributor

akioCL commented May 22, 2024

To me this looks like the spotlight itself is not working. For example in the second picture the floor of the van is not getting lit by the spotlight. If the spotlight is somehow disabled then you will not see any shadows from it. It is possible that the spotlight may be getting culled incorrectly in this case. Doe the issue repro 100%? Tagging @akioCL for visibility.

I tested on Android and is working. It seems is an iOS issue.

@moudgils moudgils removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/graphics This item is related to the Atom renderer or graphics. kind/bug Categorizes issue or PR as related to a bug. sig/graphics-audio Categorizes an issue or PR as relevant to SIG graphics-audio.
Projects
None yet
Development

No branches or pull requests

5 participants