Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Language Request: [Fennel] #578

Open
1 task
y-mx-b opened this issue Feb 4, 2022 · 11 comments
Open
1 task

New Language Request: [Fennel] #578

y-mx-b opened this issue Feb 4, 2022 · 11 comments
Labels

Comments

@y-mx-b
Copy link

y-mx-b commented Feb 4, 2022

[Fennel]

Fennel is a Lisp that compiles to Lua. It combines the flexibility of Lisp with the speed and simplicity of Lua.

Logo

https://fennel-lang.org/logo.svg

Upstream support

  • tokei does not support this language.
@y-mx-b y-mx-b added good first issue Good for newcomers enhancement New feature or request labels Feb 4, 2022
@y-mx-b
Copy link
Author

y-mx-b commented Feb 4, 2022

Made a pull request to the tokei repo for Fennel language support

@o2sh
Copy link
Owner

o2sh commented May 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@o2sh o2sh added the stale label May 16, 2022
@spenserblack
Copy link
Collaborator

😢 Looks like tokei hasn't had a merged PR for language support in a while. Perhaps the maintainer should be pinged to check if they're still planning to accept language PRs and make releases.

@o2sh
Copy link
Owner

o2sh commented May 16, 2022

I created an issue XAMPPRocky/tokei#911

@o2sh o2sh removed the stale label May 16, 2022
@y-mx-b
Copy link
Author

y-mx-b commented May 17, 2022

My Fennel support pull request has just been merged into tokei's master branch. Are there any plans to use tokei branches other than official releases for onefetch?

@spenserblack
Copy link
Collaborator

Unless we decide not to publish on crates.io, I believe we need to use released versions for all of our dependencies. I don't think crates.io accepts crates that depend on repository links/branches.

@o2sh
Copy link
Owner

o2sh commented Aug 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@o2sh o2sh added the stale label Aug 21, 2022
@o2sh
Copy link
Owner

o2sh commented Nov 20, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@o2sh o2sh added the stale label Nov 20, 2022
@spenserblack
Copy link
Collaborator

@o2sh Do we have a policy for stale PRs that are blocked by external dependencies? Should we consider them stale or still valid?

@o2sh
Copy link
Owner

o2sh commented Nov 20, 2022

I think they're still valid, we can tag the issue with the "blocked: tokei" label for it to be exempted from stale.

@o2sh o2sh added blocked: tokei and removed stale enhancement New feature or request good first issue Good for newcomers labels Nov 20, 2022
@spenserblack spenserblack mentioned this issue Nov 28, 2022
1 task
@spenserblack
Copy link
Collaborator

Linking #1152 to PRs and issues that will probably be affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants