Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add Smalltalk support #343

Open
Kirtai opened this issue Dec 12, 2020 · 6 comments
Open

Please add Smalltalk support #343

Kirtai opened this issue Dec 12, 2020 · 6 comments
Labels

Comments

@Kirtai
Copy link

Kirtai commented Dec 12, 2020

When used in a Smalltalk repo like https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev it misidentifies it as CSS.

@HallerPatrick
Copy link
Contributor

What even is the Smalltalk logo?

Is it this?

Smalltalk-powered

So should the ascii art be a hot air balloon?

@Kirtai
Copy link
Author

Kirtai commented Dec 12, 2020

Yes, it's a colourful, striped hot air balloon. Searching for "Smalltalk balloon" will give lots of examples. The original was on the cover of Byte Magazine here

@spenserblack
Copy link
Collaborator

spenserblack commented Dec 12, 2020

Currently, onefetch uses tokei to detect languages. It appears that tokei doesn't yet support smalltalk (see XAMPPRocky/tokei#316).

@Kirtai, If you're interested in adding Smalltalk support to tokei, it's very easy -- all you should need to do is add a new object with a few keys to a JSON file, and create a test file for the added language.

@stale
Copy link

stale bot commented Mar 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 14, 2021
@o2sh o2sh removed the wontfix label Mar 14, 2021
@o2sh o2sh added the pinned label May 2, 2021
@jake-87
Copy link
Contributor

jake-87 commented Oct 26, 2021

XAMPPRocky/tokei/pull/839 should add support for smalltalk, apon which it can be added to onefetch.

@Kirtai , if you want to get the groundwork ready for smalltalk in onefetch, hopefully the PR in tokei should be resolved soon.

@o2sh o2sh added good first issue Good for newcomers help wanted Extra attention is needed and removed pinned labels Oct 27, 2021
@o2sh o2sh added blocked: tokei and removed help wanted Extra attention is needed good first issue Good for newcomers labels Nov 20, 2022
@spenserblack
Copy link
Collaborator

Linking #1152 to PRs and issues that will probably be affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants