-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect short-circuiting of "task runner"? #384
Comments
I wouldn't call it incorrect per se. It it inconsistent though, using How I understand what happens in case of error, in both versions:
However, if the generator handled the error, then it would make sense to have either
The decision to abort (handling or not handling the error and returning or not returning) should be up to the task, not up to the runner. So, I agree that the use case with |
Hi Nicholas,
Location: Chapter 11 > Page 238 > "Promise-Based Asynchronous Task Running" > code at top of page
The following code block almost at the top puzzles me:
You're side-stepping (pun intended) the call to the next
step()
, which doesn't seem right. In fact, your next take on it does take care tostep()
after thetask.throw(err)
.What am I missing here?
The text was updated successfully, but these errors were encountered: