Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Calendar Invites don't show up in the body #132

Open
2 of 3 tasks
nirmit opened this issue Oct 26, 2017 · 9 comments
Open
2 of 3 tasks

Calendar Invites don't show up in the body #132

nirmit opened this issue Oct 26, 2017 · 9 comments

Comments

@nirmit
Copy link
Contributor

nirmit commented Oct 26, 2017

The body shows as blank. It seems to be an issue with the "events" attribute in the message object. This is specific to ICS invite based emails.

This issue can be split up into the below desired functionality:

  • (@nirmit completed) Show ICS as attachment
  • (@nirmit completed) Show invite content (date, time, timezone if specified, name, location, description, etc) with no action buttons
  • (Unassigned) Implement RSVP action buttons
@nirmit
Copy link
Contributor Author

nirmit commented Oct 26, 2017

As a starting point, we can atleast show the ICS as an attachment. What do you guys think, @seesemichaelj @dweremeichik ?

@mikeseese
Copy link
Contributor

hm i want to say i've seen this issue, but sending myself a calendar invite from google calendar didn't work (i was able to receive an invite.ics attachment as well as a email of the details of the invite). are you able to recreate this?

i agree, that at a minimum, the ICS should show as an attachment

a nicer improvement would have a dedicated header at the top of the invite that had parsed info from the ICS attachment

we can separate these as two separate issues if desired

@nirmit
Copy link
Contributor Author

nirmit commented Oct 26, 2017

Yes. The reason the Calendar invite works from Google is because the ICS is an attachment to the HTML invitation content that comes along. If you use exchange, you will see that the ICS is not correctly parsed.

I agree on showing the invite content inline in a better way, but I am not sure if I would be able to implement invite actions - Accept, Tentative or Decline! :(

@mikeseese
Copy link
Contributor

well i think there's three different iterations of this:

  1. show ICS as attachment
  2. show invite content (date, time, timezone if specified, name, location, description, etc) with no action buttons
  3. implement RSVP action buttons

I'll add these as checkboxes in your first comment on this Issue, and people can "pick" which ones they want to work on, and they'll get checked when merged

@nirmit
Copy link
Contributor Author

nirmit commented Oct 26, 2017

Great! I can work on the ICS attachment one.

@mikeseese
Copy link
Contributor

ICS attachment completed in #133

@nirmit
Copy link
Contributor Author

nirmit commented Oct 26, 2017

In order to complete pt. 2 from the list above, I would suggest including the meeting content along with the attachments. Since the meeting header wouldn't have any actionable buttons, the users can still open the .ics to accept/decline meetings. Let me know if it makes sense.

@mikeseese
Copy link
Contributor

I agree

@dweremeichik
Copy link
Member

Auto closed by merge. Reopening.

@dweremeichik dweremeichik reopened this Nov 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants