Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Make an option to download prebuilt FFMPEG binaries #162

Open
Asp3ctus opened this issue Oct 5, 2016 · 3 comments
Open

Comments

@Asp3ctus
Copy link

Asp3ctus commented Oct 5, 2016

in readme it said : Working media out of the box (sound and video)
but i had to download binary https://github.com/iteufel/nwjs-ffmpeg-prebuilt/releases
to get mp4 support in html5

@jyapayne
Copy link
Collaborator

jyapayne commented Oct 5, 2016

Right. It should say "working open source audio and video". The formats supported are only the open source formats like ogg and matroska. The reason is so that if you want to sell what you bundle, you aren't restricted under a license. Note that if you use FFMPEG, you are restricted under the GPL license and cannot legally sell what you bundle without providing full source code.

@Asp3ctus
Copy link
Author

Asp3ctus commented Oct 5, 2016

Well i guess it should be a setting then

@jyapayne jyapayne changed the title ffmpeg binary [Feature Request] Make an option to download prebuilt FFMPEG binaries Oct 7, 2016
@jyapayne
Copy link
Collaborator

jyapayne commented Oct 7, 2016

You're correct. It should be a setting to download from an external source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants