-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many blank lines in browse mode after #16471 merge #16554
Labels
bug/regression
feature/browse-mode
p4
https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
triaged
Has been triaged, issue is waiting for implementation.
Milestone
Comments
5 tasks
cc: @SaschaCowley |
5 tasks
seanbudd
pushed a commit
that referenced
this issue
May 23, 2024
…16585) Fixes #16554 Summary of the issue: #16471 introduced a regression whereby many blank lines were reported in browse mode. Description of user facing changes Extraneous blank lines are no longer reported in browse mode. Description of development approach Updated checks in gecko_ia2.cpp: Check that the length of name is non-zero (SysStringLen returns 0 if the BSTR passed is null) Added check that description's value is not the empty string, as checking that it has a value is necessary but not sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug/regression
feature/browse-mode
p4
https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
triaged
Has been triaged, issue is waiting for implementation.
Steps to reproduce:
Code Review Checklist:
headingActual behavior:
NVDA reports three empty lines below the heading before it reports the first list item
Expected behavior:
NVDA directly moves to the first list item.
Additional context
There are also empty lines added in the github pull request overview, for example.
System configuration
NVDA installed/portable/running from source:
Installed
NVDA version:
alpha-31919,383b2044
Windows version:
Windows 11 23H2
Name and version of other software in use when reproducing the issue:
Firefox 125.0.3
Other questions
Does the issue still occur after restarting your computer?
Yes
Have you tried any other versions of NVDA? If so, please report their behaviors.
Yes, I reverted a1848dd when running from source and the issue disappeared.
If NVDA add-ons are disabled, is your problem still occurring?
Yes
Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?
N/A
The text was updated successfully, but these errors were encountered: