loading.throttle doesn't seem to work

[hecktarzuli]

Version

v2.5.1

Reproduction link

https://codesandbox.io/s/zx50vm1jql

Steps to reproduce

Go to link
Slow down network (either delay 10s or change profile to 1k/sec up/down)
notice the second you click About button, the progress bar shows, even though throttle is set to 5000

What is expected ?

Per documentation, progress bar shouldn't show until throttle is expired

What is actually happening?

Progress bar is shown right away

_{This bug report is available on Nuxt community (#c9037)}

[zhj135]

in your reproduction link, you should replace 'thottle' to 'throttle'

[hecktarzuli]

LOL, I guess it was my turn to be 'that guy' ... Fixed, problem still remains (yes I restarted the sandbox & yes it was the right syntax locally when we found the problem).. @manniL

[stale]

Thanks for your contribution to Nuxt.js!
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you would like this issue to remain open:

1. Verify that you can still reproduce the issue in the latest version of nuxt-edge
2. Comment the steps to reproduce it

Issues that are labeled as pending will not be automatically marked as stale.

[hecktarzuli]

ping @manniL

[stale]

Thanks for your contribution to Nuxt.js!
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you would like this issue to remain open:

1. Verify that you can still reproduce the issue in the latest version of nuxt-edge
2. Comment the steps to reproduce it

Issues that are labeled as pending will not be automatically marked as stale.

[manniL]

Can't repro in Firefox 🤔

[hecktarzuli]

Grr, now I can't repro either in the sandbox (I was able to repro before dozens of times). I'll check local and verify everything is ok now.

[hecktarzuli]

Local dev looks fine now too. I assume this was fixed in a later version or something.

[gijsroge]

@hecktarzuli I forked your sandbox and added a real http request in the fetch so it would do an actual request and take some time to resolve.

As you can see I set the throttle to 1s and it still flashes between navigating.

https://codesandbox.io/s/codesandbox-nuxt-loading-throttle-issue-yhkp3

@manniL could you review again?
@hecktarzuli can you re-open if you confirm?

I can confirm this issue does exist but it has nothing to do with Nuxt itself, it's only when you use the Axios module.

This is a knowns issue and has an open pull request.
nuxt-community/axios-module#247

[hecktarzuli]

Yeah this is weird. In my local dev, setting throttle to 20s still shows the progress bar immediately. I don't know how this would be anything other than nuxt's fault. It's their component that should be abiding by the nuxt.config.js

[gijsroge]

@hecktarzuli no the @nuxtjs/axios module calls the set method on the loading component that immediately shows the loading bar. This is by design.

The pull request I referenced is their to discus if the @nuxtjs/axios module should change its behavior so it respects the throttle configuration set by the user.

[hecktarzuli]

That abstraction is pretty messy. IMHO, Nuxt should expose a loading object that webpack, axios and other junk can add and remove stuff from as things are loaded. Then the only thing the loading component would need to do is decide how to render that abstraction over time.

In other words, the axios plugin should NOT be playing with the loading component, what it should be doing it just telling nuxt its loading X many resources and remove them when they are done loading. (@manniL)