Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The sqlite feature changes behavior of many tests but tests should be additive #744

Open
cactusdualcore opened this issue Feb 4, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@cactusdualcore
Copy link
Contributor

The Cargo book states about features

A consequence of this is that features should be additive. That is, enabling a feature should not disable functionality, and it should usually be safe to enable any combination of features. A feature should not introduce a SemVer-incompatible change.

A lot of code branches on whether the "sqlite" or "sqlite-dynlib" features are enabled. This is not necessarily semver breaking, but most of that code that doesn't have a hard dependency the SqliteBackedHistory. Examples and even more importantly tests shouldn't alter behaviour like this (e.g. in history/cursor.rs).

@cactusdualcore cactusdualcore added the enhancement New feature or request label Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant