Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background color is invalid/corrupted #5

Open
ericxu360 opened this issue Mar 31, 2024 · 0 comments
Open

Background color is invalid/corrupted #5

ericxu360 opened this issue Mar 31, 2024 · 0 comments

Comments

@ericxu360
Copy link

Love the theme. Great work with it!

As of the latest update the background color does not have commas separating the RGB values. As an example in color-schemes/cherry.colors:

[Colors:Window]
BackgroundAlternate=54,56,62
BackgroundNormal=313142
DecorationFocus=230,78,129
DecorationHover=230,78,129
ForegroundActive=101,219,255
ForegroundInactive=153,153,153
ForegroundLink=70,154,244
ForegroundNegative=191,3,3
ForegroundNeutral=176,128,0
ForegroundNormal=234,234,234
ForegroundPositive=0,110,40
ForegroundVisited=61,251,115

Probably it should be (which does display the new darker color)

[Colors:Window]
BackgroundAlternate=54,56,62
BackgroundNormal=31,31,42
DecorationFocus=230,78,129
DecorationHover=230,78,129
ForegroundActive=101,219,255
ForegroundInactive=153,153,153
ForegroundLink=70,154,244
ForegroundNegative=191,3,3
ForegroundNeutral=176,128,0
ForegroundNormal=234,234,234
ForegroundPositive=0,110,40
ForegroundVisited=61,251,115

Note the change in the third line. I imagine there are similar errors elsewhere -- I can look and make a PR if you would like.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ericxu360