Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this more modular #5

Open
todo bot opened this issue Dec 20, 2018 · 2 comments
Open

Make this more modular #5

todo bot opened this issue Dec 20, 2018 · 2 comments
Assignees

Comments

@todo
Copy link

todo bot commented Dec 20, 2018

# TODO: Make this more modular
# TODO: Use translators to determine best storage type
# ...
if not storage:
if isinstance(scrap, string_types):
storage = 'unicode'


This issue was generated by todo based on a TODO comment in 7b3871a when #3 was merged. cc @MSeal.
@todo todo bot assigned MSeal Dec 20, 2018
@todo todo bot added the todo 🗒️ label Dec 20, 2018
@rgbkrk
Copy link
Member

rgbkrk commented Feb 15, 2019

I wonder if each of these TODOs that are near each other should be combined.

@MSeal
Copy link
Member

MSeal commented Feb 16, 2019

Yes they should be imo.

MSeal added a commit to MSeal/scrapbook that referenced this issue Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants