Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality specific logging to validate_bookstore #160

Open
4 tasks
mpacer opened this issue Aug 2, 2019 · 1 comment
Open
4 tasks

Add functionality specific logging to validate_bookstore #160

mpacer opened this issue Aug 2, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@mpacer
Copy link
Member

mpacer commented Aug 2, 2019

In #159 we realized that there is utility in logging more information at the point of validating the bookstore settings. To keep the PR more tightly scoped we only added it to the file system cloning validation.

We need to make a decision on if we want to add logs for:

  • overall bookstore validation
  • archive validation
  • publishing validation
  • s3 cloning validation
@willingc willingc added the enhancement New feature or request label Aug 2, 2019
@willingc
Copy link
Member

willingc commented Aug 2, 2019

Nicely written @mpacer. To me, addition of the logs on the others depends on whether this information would be useful for monitoring or debugging. If the admin or developer would benefit, please feel free to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants