Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter BookstoreVersionHandler response #132

Open
mpacer opened this issue Jun 11, 2019 · 2 comments
Open

Alter BookstoreVersionHandler response #132

mpacer opened this issue Jun 11, 2019 · 2 comments

Comments

@mpacer
Copy link
Member

mpacer commented Jun 11, 2019

This arose in the context of #130.

This will change the validation logic available, and so would be relevant for nteract_on_jupyter as it uses this information as part of it's startup page.

@stormpython @captainsafia

@mpacer mpacer changed the title Remove "bookstore": True from BookstoreVersionHandler response Alter BookstoreVersionHandler response Jun 14, 2019
@mpacer
Copy link
Member Author

mpacer commented Jun 14, 2019

Initially, this was a statement to remove the "bookstore": True field from the response, but in conversation with @MSeal and @willingc it became clear that we might want to reconsider the structure of this endpoint altogether.

@stormpython
Copy link
Member

@mpacer thats fine. I will open an issue and PR in the nteract repo to address this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants