Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled CaseClauseError from bug in Posion #95

Open
dbernheisel opened this issue Feb 12, 2020 · 0 comments
Open

Unhandled CaseClauseError from bug in Posion #95

dbernheisel opened this issue Feb 12, 2020 · 0 comments

Comments

@dbernheisel
Copy link

dbernheisel commented Feb 12, 2020

When Shopify.Response is trying to parse the body of the response, I'm seeing a CaseClauseError exception occur sometimes from this line. It's because of a bug in Poison (I'm using Poison version 3.1.0). It's not a documented signature, so I understand it may not be this shopify lib's responsibility to fix it, however we could prevent it by modifying the mix.exs requirement for poison to either avoid this bugged version, or add a clause to capture it.

Poison 4.x returns to a 2-item error tuple so it should be compatible again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant