Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supply VM console with default config #3450

Open
AnnaShaleva opened this issue May 20, 2024 · 0 comments · May be fixed by #3477
Open

Supply VM console with default config #3450

AnnaShaleva opened this issue May 20, 2024 · 0 comments · May be fixed by #3477
Labels
bug Something isn't working cli Command line interface I3 Minimal impact S4 Routine U3 Regular
Milestone
v0.106.3

Comments

@AnnaShaleva
Copy link
Member

Current Behavior

neo-go vm can't be started without node configuration since #2528. Although it's mandatory to have some configuration for it, we deliver NeoGo releases as a single executable, which results in:

anna@kiwi:~/Documents/GitProjects$ ./neo-go vm
config './config/protocol.privnet.yml' doesn't exist

Expected Behavior

VM CLI should run properly even without configuration.

Possible Solution

Provide default configuration hard-coded in the code to VM CLI during start (if no user-defined config specified).
@AnnaShaleva AnnaShaleva added bug Something isn't working I3 Minimal impact U3 Regular cli Command line interface S4 Routine labels May 20, 2024
@AnnaShaleva AnnaShaleva modified the milestones: v0.107.0, v0.106.1 May 20, 2024
@AnnaShaleva AnnaShaleva mentioned this issue May 23, 2024
Open
@roman-khimov roman-khimov modified the milestones: v0.106.1, v0.106.2 Jun 1, 2024
AliceInHunterland added a commit that referenced this issue Jun 4, 2024
@AliceInHunterland
vm: add default config
a147a60 
Supply VM console with default config.

Close #3450

Signed-off-by: Ekaterina Pavlova <[email protected]>
@AliceInHunterland AliceInHunterland linked a pull request Jun 4, 2024 that will close this issue
Open
AliceInHunterland added a commit that referenced this issue Jun 5, 2024
@AliceInHunterland
vm: add default config
c62d3df 
Supply VM console with default config.

Close #3450

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jun 5, 2024
@AliceInHunterland
cli vm: add default config if nothing passed
bdee5e4 
Supply VM console with default config.

Close #3450

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jun 5, 2024
@AliceInHunterland
cli vm: add default config if nothing passed
319faeb 
Supply VM console with default config.

Close #3450

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jun 6, 2024
@AliceInHunterland
cli vm: add default config if nothing passed
11b4a98 
Supply VM console with default config.

Close #3450

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jun 6, 2024
@AliceInHunterland
cli vm: add default config if nothing passed
3ebcc94 
Supply VM console with default config.

Close #3450

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jun 6, 2024
@AliceInHunterland
cli vm: add default config if nothing passed
22ad6a6 
Supply VM console with default config.

Close #3450

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jun 6, 2024
@AliceInHunterland
cli vm: add default config if nothing passed
bf02042 
Supply VM console with default config.

Close #3450

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jun 6, 2024
@AliceInHunterland
cli vm: add default config if nothing passed
2549bd9 
Supply VM console with default config.

Close #3450

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jun 6, 2024
@AliceInHunterland
cli vm: add default config if nothing passed
1cba676 
Supply VM console with default config.

Close #3450

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jun 6, 2024
@AliceInHunterland
cli vm: add default config if nothing passed
6128144 
Supply VM console with default config.

Close #3450

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jun 7, 2024
@AliceInHunterland
cli vm: add default config if nothing passed
950f35d 
Supply VM console with default config.

Close #3450

Signed-off-by: Ekaterina Pavlova <[email protected]>
@roman-khimov roman-khimov modified the milestones: v0.106.2, v0.106.3 Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working cli Command line interface I3 Minimal impact S4 Routine U3 Regular
Projects
None yet
Milestone
v0.106.3
Development

Successfully merging a pull request may close this issue.

cli: add embadded node config nspcc-dev/neo-go
2 participants
@roman-khimov @AnnaShaleva