Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-nx-workspace strips version from preset option #23174

Open
1 of 4 tasks
zachlewton opened this issue May 3, 2024 · 2 comments · May be fixed by #23284
Open
1 of 4 tasks

create-nx-workspace strips version from preset option #23174

zachlewton opened this issue May 3, 2024 · 2 comments · May be fixed by #23284

Comments

@zachlewton
Copy link

Current Behavior

right now npx create-nx-workspace my-workspace --preset=@org/[email protected] does not respect the version and defaults to latest

Expected Behavior

this command would respect the version passed to it

GitHub Repo

No response

Steps to Reproduce

This is just an example that mirrors my situation:
(have go installed locally)

  1. run npx create-nx-workspace go-workspace --preset=@nx-go/[email protected]
  2. cd go-workspace
  3. run nx report

you will see it installed the latest nx-go rather than the version you specified
https://github.com/nx-go/nx-go/releases

Nx Report

Node   : 18.18.2
OS     : darwin-arm64
npm    : 9.8.1

nx             : 18.3.4
@nx/workspace  : 18.3.4
@nx/devkit     : 18.3.4
@nrwl/tao      : 18.3.4
---------------------------------------
Registered Plugins:
@nx-go/nx-go
---------------------------------------
Community plugins:
@nx-go/nx-go : 3.0.0

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

@xiongemi
Copy link
Collaborator

xiongemi commented May 9, 2024

i submit a pr #23174 to install the specified version for 3rd party preset. however, for @nx-go/[email protected], it does not have preset generator for this version.
i got an error:

 NX   Failed to apply preset: @nx-go/nx-go

when I try to run the command.
i think the preset generator for @nx-go/nx-go is added for 3.0.0

@zachlewton
Copy link
Author

yeah sorry i was just using that as an example but probably should have picked one with valid generator . didnt realize that was the case , my bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants