Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail migration from 16.8.0 to 17.2.0 #22956

Closed
1 of 4 tasks
JosepSalvat opened this issue Apr 23, 2024 · 1 comment · Fixed by #23069
Closed
1 of 4 tasks

Fail migration from 16.8.0 to 17.2.0 #22956

JosepSalvat opened this issue Apr 23, 2024 · 1 comment · Fixed by #23069
Assignees
@AgentEnder
Labels
scope: misc Misc issues type: bug

Comments

@JosepSalvat
Copy link

Current Behavior

I'm trying to migrate from 16.8.0 to 17.2.0 and after that I'll update to the latest version. But it doesn't work.
I do nx migrate 17.2.0
then I revert all the changes from package.json that are not nx related
then yarn
Then nx migrate --run-migrations

but it's failing:

` > NX Running migrations from 'migrations.json'

NX Failed to run 16.8.0-escape-dollar-sign-env from nx. This workspace is NOT up to date!

NX Cannot read properties of null (reading 'split')
`

Expected Behavior

it should work the update to first 17.2.0

GitHub Repo

No response

Steps to Reproduce

I'm trying to migrate from 16.8.0 to 17.2.0 and after that I'll update to the latest version. But it doesn't work.
I do nx migrate 17.2.0
then I revert all the changes from package.json that are not nx related
then yarn
Then nx migrate --run-migrations

but it's failing:

` > NX Running migrations from 'migrations.json'

NX Failed to run 16.8.0-escape-dollar-sign-env from nx. This workspace is NOT up to date!

NX Cannot read properties of null (reading 'split')
`

Nx Report

>  NX   Report complete - copy this into the issue template

   Node   : 21.7.3
   OS     : linux-x64
   yarn   : 3.6.0
   
   nx                 : 17.2.0
   @nx/js             : 17.2.0
   @nx/jest           : 17.2.0
   @nx/linter         : 17.2.0
   @nx/eslint         : 17.2.0
   @nx/workspace      : 17.2.0
   @nx/cypress        : 17.2.0
   @nx/devkit         : 17.2.0
   @nx/eslint-plugin  : 17.2.0
   @nx/react          : 17.2.0
   @nrwl/tao          : 17.2.0
   @nx/web            : 17.2.0
   nx-cloud           : 18.0.0
   typescript         : 4.6.3
   ---------------------------------------
   Community plugins:
   rxjs : 6.6.7

Failure Logs

No response

Package Manager Version

yarn 3.6.0

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response
@AgentEnder
Copy link
Member

You can likely remove that migration from migrations.json and then run the migrations, I'll look into why that ones failing.

@AgentEnder AgentEnder self-assigned this Apr 29, 2024
@AgentEnder AgentEnder added the scope: misc Misc issues label Apr 29, 2024
@AgentEnder AgentEnder mentioned this issue Apr 29, 2024
Merged
FrozenPandaz pushed a commit that referenced this issue May 13, 2024
@AgentEnder
fix(misc): guard against failure to decode file in migration (#23069)
593790d 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
A migration in `nx` (escape-dollar-sing-env-variables) does not guard
against non utf-8 files, and can result in a crash during the migration
run.

## Expected Behavior
If it fails to parse a file, we'll log a message and keep going.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #22956
FrozenPandaz pushed a commit that referenced this issue May 14, 2024
@AgentEnder @FrozenPandaz
fix(misc): guard against failure to decode file in migration (#23069)
ac1061e 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
A migration in `nx` (escape-dollar-sing-env-variables) does not guard
against non utf-8 files, and can result in a crash during the migration
run.

## Expected Behavior
If it fails to parse a file, we'll log a message and keep going.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #22956

(cherry picked from commit 593790d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AgentEnder AgentEnder

Labels
scope: misc Misc issues type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(misc): guard against failure to decode file in migration AgentEnder/nx
2 participants
@AgentEnder @JosepSalvat