-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pull request action should surface appropriate merge strategy #99
Comments
it'd be swell if we could change the state of the button directly.. i wonder if the github api lets us do that |
from what i could find, the answer is no. or at least not yet (https://github.community/t/squash-and-merge-as-default-pull-request-merge-option/1031/38) |
Just a side comment... should we be using |
Fixup only works if you're going to be squashing the PR, unfortunately. Github PR squash-merge doesn't account for them. |
Problem:
We want to allow only squash OR rebase as valid PR merge strategies (ref: #98). Which one is appropriate depends on context, but can't be enforced automatically.
Solution:
workflows/pull-request.yml
should leave a bot comment on the PR saying something likeThis PR should be merged via <MERGE_STRATEGY>
based on the following logic:The text was updated successfully, but these errors were encountered: