Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Methods for Layouts #45

Open
Cliftonz opened this issue Oct 3, 2023 · 3 comments
Open

Add Missing Methods for Layouts #45

Cliftonz opened this issue Oct 3, 2023 · 3 comments
Assignees

Comments

@Cliftonz
Copy link
Contributor

Cliftonz commented Oct 3, 2023

Some endpoints of the following section can't be hit from this SDK.

We would like to ensure that all endpoints can be hit. For this issue, we would like to build out the Layouts

Some of these methods may already exist. 
If so no need to change/update them, just point out that they already exist and we will close the issue.

This is just to bring every SDK we have on par with all the methods available.

Check all the endpoints here and add the missing ones.

@srikanth597
Copy link
Contributor

srikanth597 commented Oct 5, 2023

None of the Layouts routes has been implemented in GO SDK, I would love to pick this & implement it.
Can you assign this to me?

@Cliftonz Cliftonz assigned Cliftonz and srikanth597 and unassigned Cliftonz Oct 5, 2023
@Cliftonz
Copy link
Contributor Author

Cliftonz commented Oct 5, 2023

@srikanth597 Assigned

@srikanth597
Copy link
Contributor

https://github.com/novuhq/go-novu/pull/65/files

@Cliftonz here's the Pull Request for the same

This is my first ever Open Source PR & also a first-ever GoLang Contribution outside personal learnings.

If you don't mind I need a favor, can you please add the Hactoberfest label to the Pull Request & to this issue that would be great for me to showcase that I have been part of the Hactoberfest 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants