-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow graceful reloads in case of certificate changes #374
Comments
Unfortunately I don't think it is likely we'll support this as it is not supported by |
Hello! Apologies if I actually don't know well the codebase to understand if Thank you. |
It's about the current architecture of websockify, so I don't think upstream Python needs to modify anything. |
I currently can't find a way to gracefully reload websockify in case the certificate changes.
With graceful I'd mean something similar to haproxy - when you reload haproxy, all existing connections are still served, but new ones receive the new certificate. At the moment, I restart websockify, which terminates any connections.
This would - I imagine - become more needed with let's encrypt, especially if they intend to shorten the certificate validity further.
If this is already possible, documentation would help in avoiding similar questions. ;)
The text was updated successfully, but these errors were encountered: