Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual glitch in non-rounded dark dialog #455

Open
srknzl opened this issue Apr 3, 2021 · 1 comment
Open

Visual glitch in non-rounded dark dialog #455

srknzl opened this issue Apr 3, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@srknzl
Copy link

srknzl commented Apr 3, 2021

Describe the bug
Visual glitch in dark dialogs (not rounded ones)

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://nostalgic-css.github.io/NES.css/
  2. Click on "open dark dialog"
  3. See glitch

Expected behavior

Screenshots

how it is right now:

image

what it should look like:

image

Environment:

  • OS: Ubuntu 20.04
  • Browser: Chrome Version 89.0.4389.90 (Official Build) (64-bit)
  • Build environment (i.e. NodeJS): None

Suggestion(s) for fixing this issue
This css block causes this glitch, I don't know what it does.

https://github.com/nostalgic-css/NES.css/blob/master/scss/elements/dialogs.scss#L26

Disabling "position: absolute" in dev tools fixes the glitch

Additional context

@guastallaigor guastallaigor added the bug Something isn't working label Apr 5, 2021
@yslius
Copy link

yslius commented Nov 29, 2021

I think the aim was to make it similar to Container.is-dark.

image

scss\elements\containers.scss

&::after {
  position: absolute;
  top: -$border-size * 1.8;
  right: -$border-size * 1.8;
  bottom: -$border-size * 1.8;
  left: -$border-size * 1.8;
  z-index: -1;
  content: "";
  background-color: $base-color;
}

But, since it is difficult to realize on the dialog, I think that absolute is not necessary.
I sent a pull request for this matter.
#474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants