Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook Enhancement #381

Open
HiKaylum opened this issue Nov 29, 2019 · 4 comments
Open

Storybook Enhancement #381

HiKaylum opened this issue Nov 29, 2019 · 4 comments
Assignees
@HiKaylum
Labels
enhancement New feature or request

Comments

@HiKaylum
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Not a problem. We are using Storybook but not to its full potential.

Describe the solution you'd like
I want to clean up how we are currently implementing Storybook split the HTML markup and story, implement the Docs and Accessibility plugins and general clean up.

Describe alternatives you've considered
Not do it ¯_(ツ)_/¯

Additional context
N/A
@HiKaylum
Copy link
Contributor Author

Assign to me

@guastallaigor guastallaigor added the enhancement New feature or request label Nov 29, 2019
@HiKaylum
Copy link
Contributor Author

HiKaylum commented Dec 14, 2019 •
edited

I'm going to split this issue into tasks and do them in separate PRs as the current one is getting pretty large.

  • Initial Refactor
  • Branding & Accessibility
  • Snapshot Testing
  • Documentation

HiKaylum added a commit to HiKaylum/NES.css that referenced this issue Dec 14, 2019
@HiKaylum
refactor(storybook): storybook enhancement and cleanup
2e06165 
refactored the storybook codebase for all components

re nostalgic-css#381
@HiKaylum HiKaylum mentioned this issue Dec 14, 2019
Merged
@HiKaylum
Copy link
Contributor Author

HiKaylum commented Feb 5, 2020

Still working on this :) just hard finding the time with work :P

@guastallaigor
Copy link
Member

No problem 😄. Take your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HiKaylum HiKaylum

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HiKaylum @guastallaigor