Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring through pyproject.toml #452

Closed
flying-sheep opened this issue Oct 10, 2019 · 6 comments
Closed

Support configuring through pyproject.toml #452

flying-sheep opened this issue Oct 10, 2019 · 6 comments
Labels

Comments

@flying-sheep
Copy link

The tool table section of PEP 518 says that tools should store their name in [tool.<pypiname>] in pyproject.toml.

@sirosen sirosen added the feature label Dec 9, 2019
@sirosen
Copy link
Collaborator

sirosen commented Dec 9, 2019

I need to look at the TOML spec again, but I think it should be pretty reasonably possible to put the contents of nose2.cfg into [tool.nose2] in pyproject.toml
We'll have to pull in a TOML parser for this, but it looks like toml supports old pythons, so it won't be much of an issue.

I'd be happy to review a PR adding support. (I'm unlikely to work on this myself unless there's an indication of general demand.)

@flying-sheep
Copy link
Author

flying-sheep commented Dec 9, 2019

It’s more of a “it’s the correct way to do it” thing, i.e. examples should be updated and the old way should be deprecated. I’m not using nose2, I’m just maintaining a list of projects that have support already.

@sirosen
Copy link
Collaborator

sirosen commented Dec 9, 2019

Gotcha. In that case, thanks for being a good citizen and flagging this for me. 👍

Since nose2 is a "maintenance first" project at this stage in its life, I just try to set clear expectations on these things.

@laike9m
Copy link

laike9m commented Apr 5, 2020

Definitely want to see this happen.

@sirosen
Copy link
Collaborator

sirosen commented May 29, 2024

Via #596, #606 I now have this merged into main.

I'll be releasing this week, at which point I'll close this issue and anyone interested should hopefully see a ping that pyproject.toml support is available.

@sirosen
Copy link
Collaborator

sirosen commented May 31, 2024

v0.15.0 is now available, with support for reading config from tool.nose2 in pyproject.toml. 🎉

Please open issues if you see any problems with the new version!

@sirosen sirosen closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants