Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreadable content in markdown-preview code blocks #46

Open
arcticicestudio opened this issue Nov 23, 2016 · 6 comments
Open

Unreadable content in markdown-preview code blocks #46

arcticicestudio opened this issue Nov 23, 2016 · 6 comments

Comments

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Nov 23, 2016

The color for plain text in markdown-preview code blocks is equal the background color and can therefore not be seen.

ghi-46-scrot-before

ghi-46-scrcast-before

This issuse describes a similar bug as #45.

@arcticicestudio
Copy link
Contributor Author

Changed to @markdown-preview-text-color.

ghi-46-scrot-after

@dpehrson
Copy link

dpehrson commented Mar 12, 2017

I just installed nord-atom-ui for the first time (0.10.2) and am still affected by this. Is there something else I need to do?

Beautiful theme by the way.

@arcticicestudio

@arcticicestudio
Copy link
Contributor Author

Thanks for your report 👍
This is caused by the new Theming API introduced in Atom 1.13.0.
I'll have to move this feature to the Nord Atom Syntax package because the new CSS selectors won't allow to override syntax highlighted elements outside of the syntax theme package itself. I also think that this should be supported by the syntax theme anyway since it styles a result of a language and is not related to parts of the UI.

I'll create a issue for it and add a @-mention so you can track the progress 😄

@dpehrson
Copy link

@arcticicestudio Thanks, I absolutely love the theme and am using it across everything I can.

@arcticicestudio
Copy link
Contributor Author

arcticicestudio commented Mar 26, 2017

I'll try to migrate the code to the Nord Atom UI next weekend.
In the meantime you can change the ⚛️ Atom core package markdown-preview to render previews with the GitHub style as a workaround to avoid these unreadable code blocks.
It can be changed in the package settings.

ghi-46-scrot-github-style

@arcticicestudio arcticicestudio modified the milestone: 0.8.1 Jul 2, 2017
@arcticicestudio arcticicestudio removed their assignment Dec 6, 2018
@RohanChacko
Copy link

RohanChacko commented Jun 24, 2019

I just recently installed the nord-atom-ui with the nord syntax package. But in markdown preview, any text written in code blocks is not displayed on the screen unless highlighted. Please resolve the issue.
image

@arcticicestudio arcticicestudio added the Hacktoberfest This repository participates in the Hacktoberfest label Oct 8, 2020
@arcticicestudio arcticicestudio removed the Hacktoberfest This repository participates in the Hacktoberfest label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants