Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPR: customer ip addresses saved in logs #7155

Open
Manuel-Innovapps opened this issue Apr 24, 2024 · 2 comments
Open

GDPR: customer ip addresses saved in logs #7155

Manuel-Innovapps opened this issue Apr 24, 2024 · 2 comments

Comments

@Manuel-Innovapps
Copy link
Contributor

Manuel-Innovapps commented Apr 24, 2024

nopCommerce version: 4.60.x +

Steps to reproduce the problem:

  1. Disable setting customersettings.storeipaddresses
  2. visit the store, and produce a log message that is associated to a customer. (i.e. with the following http status codes: 400, 404, 500)
  3. visit the logs in the backend, open the details page of the produced log message
  4. You will see the email of the customer with a link to the customer detail page and additionally the IP address of the customer.

Based on the GDPR this is not allowed, as with this log file the displayed IP address can be directly associated with the customer.

Proposed solution:
If customersettings.storeipaddresses is disabled, IP addresses in the logs should not be stored for registered customers (or even any customers).

var log = new Log
{
LogLevel = logLevel,
ShortMessage = shortMessage,
FullMessage = fullMessage,
IpAddress = _webHelper.GetCurrentIpAddress(),
CustomerId = customer?.Id,
PageUrl = _webHelper.GetThisPageUrl(true),
ReferrerUrl = _webHelper.GetUrlReferrer(),
CreatedOnUtc = DateTime.UtcNow
};

@AndreiMaz
Copy link
Member

@Manuel-Innovapps You've written "1. Enable setting customersettings.storeipaddresses". But in this case IP addresses will be store in the [Customer] table as well. Did you mean "1. Disable setting customersettings.storeipaddresses"? So when disabled, then IP address should not be stored in [Customer] and [Log] tables?

@Manuel-Innovapps
Copy link
Contributor Author

@AndreiMaz I'm sorry for the confision, this is exactly what I meant.

They should especially not be stored in logs, if a customerId is passed. But I think generalizing to all logs should work out just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants