Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow saving empty locales #6954

Open
RomanovM opened this issue Dec 13, 2023 · 3 comments · May be fixed by #7026
Open

Allow saving empty locales #6954

RomanovM opened this issue Dec 13, 2023 · 3 comments · May be fixed by #7026

Comments

@RomanovM
Copy link
Contributor

RomanovM commented Dec 13, 2023

nopCommerce version: 4.60

When a translation is empty the value will is not saved. We need a couple translations to be empty or blank. I believe when there is no value, the resource name is displayed. We just need nothing to be displayed.

Source: https://www.nopcommerce.com/boards/topic/98366/language-translation-empty-value

P.S. But ensure that we do not trim entered values (see the comment below)

@brandon7171
Copy link

When editing string resources, an empty value when searching brings back all resources. It would be nice for anyone who saves an empty value to have a way to filter the empty resource values. There are a lot of resources to search though to find any you saved as empty. Maybe phase 2.

@brakim
Copy link

brakim commented Jan 24, 2024

I don't see the purpose of this, but if it is implemented tt should be a setting to allow storing blanks.
It's a pretty good indicator that the key is rendered when a translation is missing.

To allow storing blank as default can be misleading and confusing.

@SelectSystemsInternational
Copy link

Also with this allow the entry of spaces
image
formattedattributes.priceadjustment has a space at the front (once you take the space out you cant put it back)

I can fix it in mine as I have a custom string that I am using to display and I added the space in the code
Maybe this is the better fix if your not doing anything about the other issue above

There are 3 strings that start with a space
FormattedAttributes.PriceAdjustment
Products.ProductAttributes.PriceAdjustment.PerItem
ProductAttributes.Quantity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants