-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder uses prices exluding tax for customer entered prices regardless of taxsettings #5826
Comments
If this issue needs to be resolved, I will be happy to do it. or if you could recommend another issue. So I could contribute something |
@UsamaShahid69 Sure. Please make a pull request |
I have made the PR for this. You can review it. PR link: #6398 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
nopCommerce version: 4.40.3
Steps to reproduce the problem:
have a problem with my shopping cart total decreasing every time i do reorder on an order including products with CustomEredenteredPrice options enabled. It only happens when PricesIncludeTax is enabled in taxsettings.
Found out that the ReOrderAsync function in the OrderProcessingService is always using
orderItem.UnitPriceExclTax regardless of taxsettings.
Original code:
Fix:
This way the customered entered price will be correct both for those who have the PricesIncludeTax option enabled or disabled :)
Source: https://www.nopcommerce.com/en/boards/topic/91910/reorder-uses-prices-exluding-tax-for-customer-entered-prices-regardless-of-taxsettings
The text was updated successfully, but these errors were encountered: