Support nexus group and improvements #9
Conversation
ieugen
commented
Oct 26, 2017
•
ieugen
commented
- nexus 3.6 version upgrade
- build file cleanup
- using reckon for version inferrence from git
- upgraded karaf plugin version (funny thing: I was involved a bit with that karaf plugin as well :) )
- fixes Plugin does not work with groups #8
- added support for extension and classifier on version endpoint
- added unit tests for path building
| Bucket bucket = tx.findBucket(repository); | ||
| log.debug("rundeck download bucket: {}", bucket); | ||
|
|
||
| if (null == bucket) { |
There was a problem hiding this comment.
if null, you should continue, found next repository
There was a problem hiding this comment.
I don't understand what you are asking, please be more explicit.
I also did not look at the code, I just copy pasted and build it. I assumed you checked.
p.s. Downloading content does not work.
There was a problem hiding this comment.
😂 Sorry
I just paste a sample code yesterday.
The key code is
if (repository.getType() instanceof GroupType) {
GroupFacet facet = repository.facet(GroupFacet.class);
return facet.leafMembers();
}
You need test it.
There was a problem hiding this comment.
I just paste a sample code yesterday.
Does this mean I have to go back to original file in git and just change the code snippet from up?
I will test it once I know what code version is ok.
Is there an easier way to doploy a new version?
I tried putting the plugin in deploy folder but it did not pick it up.
The manual way of doing install means that I have to copy files and change some test files. It should be easier than this with karaf.
There was a problem hiding this comment.
I've added some tests for version part. Download still doesn't work but it's not really needed since it's easy to build the url from GAV and download with curl:
curl -v -u user_name:password https://nexus.example.scom/repository/my-repo-name/group-id/artifact-id/3.7.3/artifact-id-3.7.3.tar.gz --output artifact-id.tar.gz
| String path = groupId.replace(".", "/") + "/" + artifactId + "/" + version + "/" + artifactId + "-" + version + ".jar"; | ||
| Asset asset = tx.findAssetWithProperty("name", path, bucket); | ||
| log.debug("rundeck download asset: {}", asset); | ||
| if (null == asset) { |
* added tests for path building
|
I tried this PR but i always got errors on nexus 3.14 :
Any idea ? |
I had the same problem for the first one. |
