Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Integrating the Forks? #3

Open
gregorwolf opened this issue Jul 14, 2021 · 4 comments
Open

Re-Integrating the Forks? #3

gregorwolf opened this issue Jul 14, 2021 · 4 comments

Comments

@gregorwolf
Copy link

Hi @DerGuteWolf and @pokrakam,

it looks like your forks are the most advanced. @nomssi mybe you can pass the owndership of the project or @DerGuteWolf and @pokrakam send pull requests so we can re-integrate here.

Best regards
Gregor

@nomssi
Copy link
Owner

nomssi commented Jul 14, 2021

Hi @gregorwolf,

the repository contains 6 manually uploaded packages:

  • 3 versions of the class diagram package (7.02, 7.40, latest)
  • 3 versions of the sequence diagram package (7.31, 7.40, latest).

So it does not support abapGit. Re-integration has low priority. I refer to existing packages:

@sdfraga created an abapGit compatible package with a version of both packages.
@pokrakam extracted 7.40 versions of both packages to an abapGit compatible fork.
@DerGuteWolf is adding the newer hyperlink-syntax of PlantUML to his fork of @pokrakam 's package.
@coreline created a nice enhancement ZUML_DIAGRAM of the the class diagram package (listed on dotabap.org)

If you are looking for the most advanced code, check the fork of @DerGuteWolf and @coreline 's package.

best regards,
JNN

@pokrakam
Copy link

@nomssi is correct. I tried to make it abapGit compatible but had to drop the different versions. Versions could be reintroduced as new branches.
I didn't do much with the code, my main effort was to try to get it to work on 7.52, but SAT doesn't produce the required input anymore. I'd still love to get the sequence diagram working, but as always time is the limiting factor.

@nomssi
Copy link
Owner

nomssi commented Jul 14, 2021

@pokrakam sequence diagram generation still works on my A4H demo system.
The trick is to generate the measurement without aggregation. You have to create and use a custom variant with the aggregation flag set to "None".

@nomssi
Copy link
Owner

nomssi commented Jul 14, 2021

I have just added a branch DerGuteWolf to my repository with a refactoring of the changes by @DerGuteWolf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants