New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong html image attributes set by featherlight #391
Comments
It's definitely possible there's a rounding error in the resizing code. A PR would be most welcome. |
Hello, I have investigated this issue. I think this hack is not useful anymore. featherlight/src/featherlight.js Lines 359 to 360 in 3d6bd02
Could you please confirm if this is ok. |
Hello,
This is one of the issues everyone has. The image in lightbox modal window is always 1px less in width and height.
Problem is negligible but screenshot of text looks blurred when the final image is resized by 1px.
Need an example from my website? No need as I can show this issue on the plugin website itself.
https://noelboss.github.io/featherlight/
Real Resolution of droplets.jpg = 1000 x 700
Featherlight resolution = 999 x 699
The text was updated successfully, but these errors were encountered: