Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty modal before iframe loads #363

Open
bradhogan opened this issue Jun 12, 2018 · 3 comments
Open

Empty modal before iframe loads #363

bradhogan opened this issue Jun 12, 2018 · 3 comments

Comments

@bradhogan
Copy link

bradhogan commented Jun 12, 2018

Bug report - you can view the issue here: http://jsfiddle.net/bradhogan1983/sxwge12m/

When using the iframe option and clicking a link to open the modal, the modal opens instantly, but the iframe takes a second to load and while loading the modal container is just a small empty box. This happens on your demo as well as my local dev site. I'll also attach a screenshot of what I'm seeing on my dev site.

Thanks!
screen shot 2018-06-12 at 2 46 13 pm

@alanef
Copy link

alanef commented Sep 4, 2019

Is there any workaround like a 'loading' spinner?

@marcandre
Copy link
Collaborator

Featherlight support spinners (check the doc). You can also specify a width and height for the iframe.

Please let me know what else Featherlight should/could be doing...

@alanef
Copy link

alanef commented Sep 4, 2019

Hi Marc,

Specifying the width and height doesn't apply during the few seconds while the iframe is connecting.

But I did find data-featherlight-loading='any html can go here'
which I'm guessing is the support for spinners? By using the appropriate html including spinning gifs as required and divs of whatever size
the small white box described above can be altered as required.

It is a great library, thank you for building it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants