-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Here is a negation overflow in lua #3627
Comments
Please open a PR for that. |
Sure, I've already opened, which is #3632, please check it, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
CVE-2020-24370 is a security vulnerability in lua. Although the CVE decription in CVE-2020-24370 said that this CVE only affected lua 5.4.0, according to lua this CVE actually existed since lua 5.2. The root cause of this CVE is the negation overflow that occurs when you try to take the negative of 0x80000000. Thus, this CVE also exists in nodemcu-firmware in the file
app/lua53/ldebug.c
.Maybe you should try to backport the fix to the lua in nodemcu-firmwaresince the original fix is for 5.4 and several functions need to be changed. I'd like to open a PR for that if necessary.
The text was updated successfully, but these errors were encountered: