Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need authorized admin to manually trigger missing builds and/or grant admin access to build server #138

Open
scosol opened this issue Apr 18, 2024 · 7 comments

Comments

@scosol
Copy link
Contributor

scosol commented Apr 18, 2024

Per https://github.com/nodejs/unofficial-builds?tab=readme-ov-file#manual-build-triggers

"Admins with access to the server can manually trigger a build using the /bin/queue-push.sh command. e.g."

It's unclear who exactly has this access-

Someone with access needs to go in and trigger the other builds missing from https://unofficial-builds.nodejs.org/download/release/v20.12.2/
(and as well, fix the space issue that caused this: #135 )

I would be willing to do this myself if someone can provide me access.

@zacthompson
Copy link

Looks like rvagg, richardlau, and sxa are all maintainers of unofficial-builds and also infra admins for the main build team, so I would guess that they have the ability to either fix the space issue or delegate powers to you...

@rvagg
Copy link
Member

rvagg commented Apr 19, 2024

Unfortunately "access" in this case is all-or-nothing, which gives access to the binaries as users get them so there's security implications for adding more people, which sucks because I'd love to add more and @scosol you've been very helpful to the project thus far!

In the meantime, if you can be specific with which builds you want then I can copypaste them into a command, it's slightly tedious for me to figure out what's missing and build the command so if you're specific about the missing assets it becomes a job of seconds rather than minutes.

For this one I've just asked it for this:

./bin/queue-push.sh -v v20.12.2 -r loong64 -r riscv64 -r x64-glibc-217 -r x64-pointer-compression -r x64-debug

hopefully by putting debug last it can fail without it impacting the others; I'll see if I can free up some disk while I'm in there

@rvagg
Copy link
Member

rvagg commented Apr 19, 2024

https://unofficial-builds.nodejs.org/logs/202404190119-v20.12.2/x64-debug.log

/usr/bin/ld: final link failed: No space left on device

still not enough space, that's a bit odd, needs further investigation

@rvagg
Copy link
Member

rvagg commented Apr 19, 2024

moved debug last so that should make the other builds a little bit more reliable for now until we either fix that or #135

@scosol
Copy link
Contributor Author

scosol commented Apr 23, 2024

@rvagg can you trigger for 18.20.2 as well?

404 -> https://unofficial-builds.nodejs.org/download/release/v18.20.2/node-v18.20.2-linux-x64-glibc-217.tar.gz

./bin/queue-push.sh -v v18.20.2 -r x64-glibc-217

@rvagg
Copy link
Member

rvagg commented Apr 24, 2024

done

@rvagg
Copy link
Member

rvagg commented Apr 24, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants