Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

running autobahn test suite #3249

Closed
KhafraDev opened this issue May 12, 2024 · 4 comments · Fixed by #3251
Closed

running autobahn test suite #3249

KhafraDev opened this issue May 12, 2024 · 4 comments · Fixed by #3251
Labels
enhancement New feature or request websocket Pull requests or issues related to websocket and its standard

Comments

@KhafraDev
Copy link
Member

We cannot move WebSocket out from experimental until we run the autobahn test suite.

https://github.com/crossbario/autobahn-testsuite

@KhafraDev KhafraDev added enhancement New feature or request websocket Pull requests or issues related to websocket and its standard labels May 12, 2024
@Uzlopak
Copy link
Contributor

Uzlopak commented May 12, 2024

Maybe we can adapt it from this?

https://github.com/search?q=repo%3Atheturtle32%2FWebSocket-Node%20autobahn&type=code

I think we should do it in two steps.

  1. Add autobahn test suite and make it run via an npm script like npm run test:autobahn
  2. Fix errors thrown by autobahn incrementally
  3. If all tests pass, add it as part of the test:websocket npm script

@KhafraDev
Copy link
Member Author

@Uzlopak thanks for the link, but I'd probably use ws' autobahn client script; a lot of what's implemented in Websocket-node is just a basic setup that the autobahn suite instructs us on how to setup already.

autobahn tests don't exit out, it generates a report with passed/failed tests as an html file. We would instead publish the report on the docs site (for example).

running the tests is relatively easy, but making a reproducible testing suite is the hard part. Also, the tests don't give information on what failed and we have to replicate each test in js which makes it hard.

@KhafraDev
Copy link
Member Author

@KhafraDev
Copy link
Member Author

index.txt

Here are the results. (rename to index.html, github wouldn't let me upload an html file...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request websocket Pull requests or issues related to websocket and its standard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants