Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treating groups of commits as one unit #12

Open
mscdex opened this issue Jan 19, 2017 · 2 comments
Open

Treating groups of commits as one unit #12

mscdex opened this issue Jan 19, 2017 · 2 comments

Comments

@mscdex
Copy link

mscdex commented Jan 19, 2017

In nodejs/node#10886 I noticed that at least for one particular PR, all but 1 of its commits were being included. I think it would be a good idea to first group commits by PR and then check that all of the commits from a particular PR are landable. If all of them aren't, then none of the commits should be included.

I think such a behavior should be default, but at the very least a command line option would be okay I suppose.

@rvagg
Copy link
Member

rvagg commented Feb 22, 2017

@mscdex can you explain further? I don't quite get it.

@mscdex
Copy link
Author

mscdex commented Feb 22, 2017

There was at least one PR that was composed of several commits. When the v7.x-staging branch was being updated to pull in backportable commits from master, it only pulled in some of the commits from that PR. I was suggesting that branch-diff should check that all commits for a PR are (cleanly) backportable before including any of the commits for a PR. This way you don't end up with a partially backported PR (which could break things).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants