Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when version has not been specified in options #86

Open
dantman opened this issue Feb 3, 2017 · 2 comments
Open

Warn when version has not been specified in options #86

dantman opened this issue Feb 3, 2017 · 2 comments
Milestone

Comments

@dantman
Copy link

dantman commented Feb 3, 2017

There is no good reason to make api calls without explicitly defining what version of the graph api you are using.

Whenever we plan to do the next major release with breaking changes we should add a warning.

The first time FB.api is called (or another method that uses the version) and version is not specified, we should emit a console.warn warning that the graph api version needs to be specified.

@thierryskoda
Copy link

👍

@dantman dantman added this to the 3.0.0 milestone Apr 15, 2017
@simison
Copy link

simison commented Aug 30, 2017

Simply warning about it would not be breaking change, though?

Requiring specifying version would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants