Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method getAppUsage() is missing from the npm package #101

Open
c-dima opened this issue May 22, 2017 · 2 comments
Open

Method getAppUsage() is missing from the npm package #101

c-dima opened this issue May 22, 2017 · 2 comments
Milestone

Comments

@c-dima
Copy link

c-dima commented May 22, 2017

When installing from npm, getAppUsage is missing and nowhere to be found in the compiled source code, but when checking the source on github, it can be found inside src/fb.js folder.
NodeJS can run ES6 natively so I'm wondering, why does the npm package contain only the compiled ES5 code?
One quick fix is to install the library directly from github (add the github url directly to package.json), but this is a bit weird as the package is on npm.

@c-dima c-dima changed the title Method getAppUsage() is missing from npm package Method getAppUsage() is missing from the npm package May 22, 2017
@dantman dantman added this to the 2.1.0 milestone May 26, 2017
@dantman
Copy link

dantman commented May 26, 2017

  • getAppUsage is part of the 2.1.0 milestone and hasn't been published to npm which is currently 2.0.0
  • This library actually uses a number of es7 and unstandardized stage-0 features that NodeJS can't run. NodeJS, also doesn't yet implement all es6 features such as imports. So the code still needs to be transpiled.
  • Most of the es6 features NodeJS implemented were added in 6.x, this library is compatible back to NodeJS 4.x which was relatively new when 2.0.0 was started. I'll consider updating the minimum NodeJS version to 6.10.x and updating the babel target to 6 when there's a reason to publish a 3.0.0 with breaking changes

@gobengo
Copy link

gobengo commented Aug 10, 2017

@c-dima I published a version with getAppUsage (latest master branch here) as 'fb2' until the owner of 'fb' gets around to it. http://npm.im/fb2 (source: https://github.com/gobengo/facebook-node-sdk). It works fine in node 7.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants