New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hostname Case-Sensitivity #637
Labels
Comments
I recommend this be resolved by standardizing the hostnames to lowercase and only loading the lowercase version of the hostname file. This could be breaking change for some.
PR welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Note: for support questions, please use StackOverflow and tag your question with
node-config
. This repository's issues are reserved for feature requests and bug reports.Before submitting a bug report, please search the issue tracker the wiki first. Many issues have already been discussed.
The wiki is located at: https://github.com/lorenwest/node-config/wiki
I'm submitting a ...
What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem:
There are two issues here that lead to confusing behavior.
hostname
value is treated as case-sensitive in the file look up even on a case-insensitive file system.hostname
can produce a different cased value depending on what tool is being used.For example:
What is the expected behavior?
This RFC indicates hostnames are case-insensitive https://tools.ietf.org/html/rfc4343
If there's too much work to treat the hostname as case-insensitive in the code-base, it would at least be better in my opinion to normalize to lowercase or uppercase and add some information to the documentation to remove the ambiguity.
There is another issue related to this question but it was closed almost 6 years ago - #235
Please tell us about your environment:
Other information
(e.g. are you using an environment besides Node.js?)
The text was updated successfully, but these errors were encountered: